Joel Brock
e74462da0b
Two bugs surfaced on first dev-server test: 1. /api/staff/file 404s for valid file ids. The old per-org check read civicrm_entity_file and required entity_id==orgId, but our upload route anchors files to the submitter's contact id, not the org's — the entity_file row is metadata-only on this install (see comment in app/api/upload/route.ts). The custom-field column is the real ownership signal, which /api/staff/report already uses, and the staff key already gates org access. Drop the bogus check; keep the entity_table whitelist as defence. 2. Same-origin PDF iframe blocked by frame-ancestors 'none'. The strict global CSP excludes /staff/report; add /api/staff/file to the same embed-friendly profile so the lightbox iframe can load. Also move the sandbox/default-src 'none' CSP to the attachment path only — a strict sandbox header breaks Chrome's PDF viewer on inline responses (it needs to load fonts and plugin-mode rendering). On inline we rely on the SAFE_INLINE_MIMES allowlist + X-Content-Type- Options + the app's global CSP.
99 lines
3.4 KiB
TypeScript
99 lines
3.4 KiB
TypeScript
import path from "node:path";
|
|
import type { NextConfig } from "next";
|
|
|
|
/**
|
|
* Security headers.
|
|
*
|
|
* Two profiles:
|
|
* - strict (default): frame-ancestors 'none' + X-Frame-Options: DENY.
|
|
* Applied to every route except the embed-friendly ones.
|
|
* - staff-embed: frame-ancestors 'self' <civi-origin>, no X-Frame-Options.
|
|
* Lets the CiviCRM "Engagement Report" extension embed /staff/report,
|
|
* and lets the lightbox iframe inside that page load the
|
|
* /api/staff/file proxy for PDF preview.
|
|
*
|
|
* The catch-all source uses a negative lookahead so it does NOT match the
|
|
* embed-friendly routes — otherwise both rules apply and the browser ANDs
|
|
* the frame-ancestors directives together, blocking embedding entirely.
|
|
*/
|
|
const isDev = process.env.NODE_ENV !== "production";
|
|
const devOnlyDynamicScript = isDev ? " 'unsafe-eval'" : "";
|
|
|
|
const buildCsp = (frameAncestors: string) =>
|
|
[
|
|
"default-src 'self'",
|
|
`script-src 'self' 'unsafe-inline'${devOnlyDynamicScript}`,
|
|
"style-src 'self' 'unsafe-inline' https://fonts.googleapis.com",
|
|
"font-src 'self' https://fonts.gstatic.com data:",
|
|
"img-src 'self' data:",
|
|
"connect-src 'self'",
|
|
`frame-ancestors ${frameAncestors}`,
|
|
"form-action 'self'",
|
|
"base-uri 'self'",
|
|
"object-src 'none'",
|
|
].join("; ");
|
|
|
|
const sharedHeaders = [
|
|
{ key: "Strict-Transport-Security", value: "max-age=63072000; includeSubDomains; preload" },
|
|
{ key: "X-Content-Type-Options", value: "nosniff" },
|
|
{ key: "Referrer-Policy", value: "same-origin" },
|
|
{
|
|
key: "Permissions-Policy",
|
|
value: "camera=(), microphone=(), geolocation=(), interest-cohort=()",
|
|
},
|
|
];
|
|
|
|
function civiOriginForCsp(): string {
|
|
const raw = process.env.CIVI_BASE_URL;
|
|
if (!raw) return "";
|
|
try {
|
|
return new URL(raw).origin;
|
|
} catch {
|
|
return "";
|
|
}
|
|
}
|
|
|
|
const strictHeaders = [
|
|
{ key: "Content-Security-Policy", value: buildCsp("'none'") },
|
|
...sharedHeaders,
|
|
{ key: "X-Frame-Options", value: "DENY" },
|
|
];
|
|
|
|
const staffEmbedHeaders = (() => {
|
|
const origin = civiOriginForCsp();
|
|
const frameAncestors = origin ? `'self' ${origin}` : "'self'";
|
|
return [
|
|
{ key: "Content-Security-Policy", value: buildCsp(frameAncestors) },
|
|
...sharedHeaders,
|
|
// Intentionally NO X-Frame-Options: frame-ancestors above is the policy.
|
|
];
|
|
})();
|
|
|
|
const nextConfig: NextConfig = {
|
|
poweredByHeader: false,
|
|
reactStrictMode: true,
|
|
// Pin Turbopack's filesystem root to THIS app's directory. Without this,
|
|
// Next 16 walks up to the parent civi-webform/ workspace (it sees two
|
|
// package-lock.json files and silently picks the outer one), which causes
|
|
// Turbopack to watch the parent node_modules/, .claude-flow/, .swarm/, and
|
|
// ruvector.db. Background writes in those trees trigger a recompile loop:
|
|
// compile → write .next/dev → re-trigger → memory blows up. The build-time
|
|
// warning surfaces the same issue.
|
|
turbopack: {
|
|
root: path.resolve(__dirname),
|
|
},
|
|
async headers() {
|
|
return [
|
|
{ source: "/staff/report", headers: staffEmbedHeaders },
|
|
// The lightbox in /staff/report iframes this proxy for inline PDF
|
|
// previews. Must share the embed-friendly profile so the browser
|
|
// doesn't block the same-origin iframe.
|
|
{ source: "/api/staff/file", headers: staffEmbedHeaders },
|
|
// Catch-all that excludes the embed-friendly routes — see header notes.
|
|
{ source: "/((?!staff/report|api/staff/file).*)", headers: strictHeaders },
|
|
];
|
|
},
|
|
};
|
|
|
|
export default nextConfig;
|