designslife/Outcut
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix: address code review findings

Browse Source 
- Fix accent color CSS variable: write to --or-accent-override
- Fix actionDelete double-fire: toolbar button first, key fallback
- Fix localStorage collision: use chrome.storage.local for sidebar
- Fix updateSettings preserving keyboard selection state
- Add document.body guard for count badge creation
This commit is contained in:
Joel Brock
2026-04-23 09:07:15 -07:00
parent 311aa0e771
commit 3eec701eb4
3 changed files with 38 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
content/behavior.js
View File

@@ -32,26 +32,27 @@ window.OutlookRelook.Behavior = (function () {
function setupRememberSidebar() {
if (!currentSettings.rememberSidebarState) return;
var savedState = localStorage.getItem('or-sidebar-collapsed');
if (savedState === 'true') {
var timer = setTimeout(function () {
var pane = OR.resolveSelector('folder-pane');
for (var i = 0; i < pane.length; i++) {
var toggle = pane[i].closest('[aria-expanded]') || pane[i].querySelector('[aria-expanded]');
if (toggle && toggle.getAttribute('aria-expanded') === 'true') {
toggle.click();
chrome.storage.local.get({ sidebarCollapsed: false }, function (result) {
if (result.sidebarCollapsed) {
var timer = setTimeout(function () {
var pane = OR.resolveSelector('folder-pane');
for (var i = 0; i < pane.length; i++) {
var toggle = pane[i].closest('[aria-expanded]') || pane[i].querySelector('[aria-expanded]');
if (toggle && toggle.getAttribute('aria-expanded') === 'true') {
toggle.click();
}
}
}
}, 2000);
cleanupFns.push(function () { clearTimeout(timer); });
}
}, 2000);
cleanupFns.push(function () { clearTimeout(timer); });
}
});
// Watch for sidebar toggle changes
var sidebarObserver = new MutationObserver(function () {
var pane = OR.resolveSelector('folder-pane');
if (pane.length > 0) {
var isVisible = pane[0].offsetWidth > 50;
localStorage.setItem('or-sidebar-collapsed', String(!isVisible));
chrome.storage.local.set({ sidebarCollapsed: !isVisible });
}
});